Support all tags #321
Support all tags #321
Conversation
|
This is already done on the latest release. |
My mistake. |
somini
force-pushed
the
feature/support-all-tags
branch
from
a23d3ec
to
e54c046
Compare
somini
force-pushed
the
feature/support-all-tags
branch
2 times, most recently
from
b9fbcc0
to
4826b55
Compare
|
Rebased to the latest master. |
somini
force-pushed
the
feature/support-all-tags
branch
from
4826b55
to
e3d9f78
Compare
|
Rebased to the latest master. |
Instead of allowing only a subset of tag names, `slugify` the tag name so that the URL is always valid. This is the same thing done on "jekyll-archives": - https://github.com/jekyll/jekyll-archives/blob/master/lib/jekyll-archives/archive.rb#L132
somini
force-pushed
the
feature/support-all-tags
branch
from
e3d9f78
to
f4ae799
Compare
|
Rebased to the latest "master. |
|
I agree that this is a better approach. It's certainly better than silently dropping tags! I'm not a maintainer here, so I can't recommend what to do next. But my suggestion would be to add some tests (e.g. tags with spaces, tags with underscores, etc), since I wouldn't be comfortable myself merging a PR without them. Finally, I think we would also need to consider backwards compatibility. At the moment, the feeds have case-sensitive paths, and the tags can contain underscores, and there will be people who have published their feeds like this already, and those feeds will need to keep working.
I dislike adding configuration options, but maybe it needs a backwards-compatibility flag? |
|
I agree, a configuration option for keeping backwards compatibility and some tests would be nice. I don't think I have much time to implement this, I'm using my branch in production for years now. If you want to take this, be my guest. |
Instead of allowing only a subset of tag names,
slugifythe tag nameso that the URL is always valid.
This is the same thing done on "jekyll-archives":
There is a possibility that the same tag slugifies to the same string, but it's probably fine.