Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html-pipeline requirement from ~> 2.2 to >= 2.2, < 4.0 #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 25, 2023

Updates the requirements on html-pipeline to permit the latest version.

Changelog

Sourced from html-pipeline's changelog.

v2.14.3 (2022-10-14)

Full Changelog

Closed issues:

  • Allow vertical-align #366
  • Since bump 2.14.2 builds are failing #363

Merged pull requests:

  • Replace EscapeUtils.escape_html with CGI.escape_html #365 (ramhoj)

v2.14.2 (2022-06-12)

Full Changelog

Merged pull requests:

  • handle invalid data urls in absolute source filter #361 (glaszig)

v2.14.1 (2022-03-31)

Full Changelog

Closed issues:

  • 2.14.0 is disconnected #358
  • I would love to use the vscode codicon.ttf in my readme.md #356
  • Html-pipeline #355
  • Canalizacion de HTML #354
  • Change branch name off of master #340
  • New feature request: team mention filter #311
  • code in header produce invalid anchor #308
  • Stop "camo"ing "github.io" #305
  • A filter to produce diffs with syntax highlighting in html, maybe. #270
  • Require pygments.rb or remove Pygments references #235
  • Allow ᴀʀɪᴀ attributes for blind people. #219
  • 'lexer' is removed from github-linguist #217
  • Please document how to use the html-pipeline binary without command‐line arguments! #213
  • PHP syntax highlight #212

v2.13.2 (2020-12-04)

Full Changelog

Merged pull requests:

  • Fix custom renderer with unsafe option missing pre lang #341 (kazk)

... (truncated)

Commits
  • 84c75b3 💎 bump to 2.14.3
  • 03ae30d Merge pull request #365 from ramhoj/use-cgi-escape-html
  • 807c23c Replace EscapeUtils.escape_html with CGI.escape_html
  • 32a21be 💎 bump to 2.14.2
  • 578f958 Merge pull request #361 from glaszig/data-url
  • 3cbad68 handle invalid data urls in absolute source filter
  • 4f1aab0 Properly release v2.14.x
  • 0e3d84e 💎 bump to 2.13.2
  • f378099 Merge pull request #341 from kazk/fix-unsafe-custom-renderer-missing-pre-lang
  • b717f31 Fix custom renderer with unsafe option missing pre lang
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [html-pipeline](https://github.com/gjtorikian/html-pipeline) to permit the latest version.
- [Release notes](https://github.com/gjtorikian/html-pipeline/releases)
- [Changelog](https://github.com/gjtorikian/html-pipeline/blob/main/CHANGELOG.md)
- [Commits](gjtorikian/html-pipeline@v2.2.0...v2.14.3)

---
updated-dependencies:
- dependency-name: html-pipeline
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 25, 2023
@dependabot dependabot bot requested a review from a team December 25, 2023 02:38
@parkr
Copy link
Member

parkr commented Dec 25, 2023

These two versions require in two different ways, so a try...LoadError will need to be added.

@parkr
Copy link
Member

parkr commented Dec 26, 2023

I took a swing at this. It's much more complicated than changing the require statement:

  1. EmojiFilter has become a NodeFilter, and HTMLPipeline.new has changed its initialization procedure.
  2. The tests use just EmojiFilter.call but the README indicates that I should be initializing the EmojiFilter when adding it to the list of node_filters, so EmojiFilter.new.call.

I don't have enough time to fix this now, but given the huge differences, I'd recommend not trying to support the old and the new like this PR suggests. Just upgrade to 3.0 and call it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant