Cleanup and version bump

jellekralt · Aug 11, 2016 · 607b0a8 · 607b0a8
1 parent eb32d09
commit 607b0a8
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1 +1,2 @@
 node_modules/
+.idea/
diff --git a/bower.json b/bower.json
@@ -1,6 +1,5 @@
 {
   "name": "angular-drag-scroll",
-  "version": "0.1.1",
   "homepage": "https://github.com/jellekralt/angular-drag-scroll",
   "authors": [
     "Jelle Kralt <[email protected]>"

diff --git a/dist/ng-drag-scroll.min.js b/dist/ng-drag-scroll.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-drag-scroll",
-  "version": "0.1.1",
+  "version": "0.2.0",
   "description": "Lightweight drag to scroll directive for AngularJS",
   "dependencies": {},
   "devDependencies": {

diff --git a/src/ng-drag-scroll.js b/src/ng-drag-scroll.js
@@ -22,11 +22,7 @@
                 var onDragStart = $parse($attributes.onDragStart);
                 var onDragEnd = $parse($attributes.onDragEnd);
                 var axis = $attributes.axis || false;
-                if($attributes.dragScrollExcludedClasses){
-                    var excludedClasses = $attributes.dragScrollExcludedClasses.split(',') || false;
-                } else {
-                    var excludedClasses = false;
-                }
+                var excludedClasses = $attributes.dragScrollExcludedClasses ? $attributes.dragScrollExcludedClasses.split(',') : [];
                 var startClientX;
                 var startClientY;
                 var lastClientX;
@@ -83,7 +79,7 @@
                         e.preventDefault();
                         e.stopPropagation();
                     }
-                    
+
                 }
 
                 /**
@@ -111,7 +107,7 @@
 
                         removeDragListeners();
                     }
-                    
+
                 }
 
                 /**
@@ -130,7 +126,7 @@
                         }
 
                         e.preventDefault();
-                    } 
+                    }
                 }
 
                 /**
@@ -147,12 +143,13 @@
                  * @param {object} element Selected element
                  */
                 function selectText (element) {
+                    var range;
                     if ($window.document.selection) {
-                        var range = $window.document.body.createTextRange();
+                        range = $window.document.body.createTextRange();
                         range.moveToElementText(element);
                         range.select();
                     } else if ($window.getSelection) {
-                        var range = $window.document.createRange();
+                        range = $window.document.createRange();
                         range.selectNode(element);
                         $window.getSelection().addRange(range);
                     }