Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: google & github providers #1362

Merged
merged 4 commits into from
Oct 18, 2023
Merged

add: google & github providers #1362

merged 4 commits into from
Oct 18, 2023

Conversation

mikah13
Copy link
Contributor

@mikah13 mikah13 commented Oct 17, 2023

WHAT

Added github/google login provider to next-auth

#1361

WHY

HOW

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Todo

  • Check env value for Google and Github before adding to NextAuth provider.

Checklist:

  • Linter
  • Tests
  • Review comments
  • Security

@codesandbox
Copy link

codesandbox bot commented Oct 17, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

⚠️ No Changeset found

Latest commit: c4a045b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @jellydn on Vercel.

@jellydn first needs to authorize it.

@ghost
Copy link

ghost commented Oct 17, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sweep-ai
Copy link

sweep-ai bot commented Oct 17, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-app-starter ❌ Failed (Inspect) Oct 18, 2023 0:10am

@jellydn
Copy link
Owner

jellydn commented Oct 18, 2023

Thanks @mikah13 👏

@jellydn jellydn merged commit 046cd02 into jellydn:main Oct 18, 2023
8 checks passed
@jellydn
Copy link
Owner

jellydn commented Oct 18, 2023

@all-contributors please add @jellydn for code. please add @mikah13 for code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants