Add opus to MP4 direct play profile #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think it would actually be preferable to merge this into master and cherry-pick the commit to the release branch later on. Would you mind fixing your earlier PR? Then, this one could be closed. |
I did a noob move and deleted my fork so re-opening my previous PR is not possible anymore. But I just changed the target branch on this one. |
Maxr1998
approved these changes
Sep 1, 2024
|
I guess that works. Sorry for taking so long to reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds OPUS to the MP4 container direct play profile. OPUS is supported for direct play in other containers, but not MP4. The MP4 spec supports OPUS.
Issues
Resolves this user's issue with unnecessary transcoding.
https://forum.jellyfin.org/t-solved-direct-play-problem-with-mp4-and-certain-codecs-on-android-native-player