Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Disable HLS #3812

Closed
wants to merge 2 commits into from
Closed

Conversation

pierfied
Copy link

Changes
Adds an option in settings to disable HLS with exoplayer.

Issues
This is a workaround for subtitles getting out of sync when skipping around/resuming certain video files when using HLS
(issue #3492).

@nielsvanvelzen
Copy link
Member

The app relies on HLS for all streams when remuxing/transcoding. I'm not strictly opposed to change that but it should be substantiated why another approach is better and properly tested.

I'm not a fan of a preference for it though, that only makes testing harder. We should do everything over HLS or nothing.

@viown
Copy link
Member

viown commented Aug 3, 2024

Subtitles going out of sync should only occur during transcoding (not while direct playing/streaming), so maybe the client can request burn-in when the video has to be transcoded?

@pierfied
Copy link
Author

pierfied commented Aug 3, 2024

In retrospect, yes, I think trying to burn in subtitles when transcoding is probably a simpler and safer solution. If that would be a preferred route, we can close this PR and open a new one.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Aug 5, 2024
@nielsvanvelzen
Copy link
Member

Can you try #3825 (or master branch since it's already merged) and let me know if that fixes those sync issues for you?

@pierfied
Copy link
Author

pierfied commented Aug 6, 2024

From a quick test it looks like it does fix the sync issue! I will go ahead and close this PR.

@pierfied pierfied closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Conflicts prevent merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants