Refactor Dockerfiles

[Gauvino]

Refactor dockerfiles for better syntax and removed unused package

[nyanmisaka]

Please rebase the PR.

[Gauvino]

@nyanmisaka why is all the building failing cause I don’t think the problem is coming from my PR or I missed something maybe I'm gonna look further when I'm home cause right now I don't have a pc for the week

[nyanmisaka]

It seems you can't use the first var in the second var when setting multiple env var in single line. https://stackoverflow.com/a/45529293

[Gauvino]

So I should revert this and keep env for every single line ?

[nyanmisaka]

ENV DEB_BUILD_OPTIONS=noddebs \
    DEBIAN_FRONTEND=noninteractive \
    ARCH=BUILD_ARCHITECTURE \
    GCC_VER=GCC_RELEASE_VERSION \
    LLVM_VER=LLVM_RELEASE_VERSION \
    SOURCE_DIR=/ffmpeg \
    ARTIFACT_DIR=/dist \
    TARGET_DIR=/usr/lib/jellyfin-ffmpeg

ENV DPKG_INSTALL_LIST=${SOURCE_DIR}/debian/jellyfin-ffmpeg6.install \
    PATH=${TARGET_DIR}/bin:${PATH} \
    PKG_CONFIG_PATH=${TARGET_DIR}/lib/pkgconfig:${PKG_CONFIG_PATH} \
    CFLAGS="-I${TARGET_DIR}/include $CFLAGS" \
    CPPFLAGS="-I${TARGET_DIR}/include $CPPFLAGS" \
    CXXFLAGS="-I${TARGET_DIR}/include $CXXFLAGS" \
    LDFLAGS="-Wl,-rpath=${TARGET_DIR}/lib -L${TARGET_DIR}/lib" \
    LD_LIBRARY_PATH=${TARGET_DIR}/lib:${TARGET_DIR}/lib/mfx:${TARGET_DIR}/lib/xorg:${LD_LIBRARY_PATH}

[Gauvino]

With this changed the script can build ?

[nyanmisaka]

Nope. But later build steps would require these envs.

[Gauvino]

Didn't need to change this as it works with the change I made, don't need to separate in two of them

[nyanmisaka]

@Gauvino Please refer to the FFBUILD_TOOLCHAIN in this file. It's a copy of https://github.com/BtbN/FFmpeg-Builds, they are more expert on this than me.

jellyfin-ffmpeg/builder/images/base-linux64/Dockerfile

Lines 42 to 61 in bc59f46

	ENV FFBUILD_TOOLCHAIN=x86_64-ffbuild-linux-gnu
	ENV PATH="/opt/ct-ng/bin:${PATH}" \
	FFBUILD_TARGET_FLAGS="--pkg-config=pkg-config --pkg-config-flags=--static --cross-prefix=${FFBUILD_TOOLCHAIN}- --arch=x86_64 --target-os=linux" \
	FFBUILD_CROSS_PREFIX="${FFBUILD_TOOLCHAIN}-" \
	FFBUILD_RUST_TARGET="x86_64-unknown-linux-gnu" \
	FFBUILD_PREFIX=/opt/ffbuild \
	FFBUILD_CMAKE_TOOLCHAIN=/toolchain.cmake \
	PKG_CONFIG=pkg-config \
	PKG_CONFIG_LIBDIR=/opt/ffbuild/lib/pkgconfig:/opt/ffbuild/share/pkgconfig \
	CC="${FFBUILD_TOOLCHAIN}-gcc" \
	CXX="${FFBUILD_TOOLCHAIN}-g++" \
	LD="${FFBUILD_TOOLCHAIN}-ld" \
	AR="${FFBUILD_TOOLCHAIN}-gcc-ar" \
	RANLIB="${FFBUILD_TOOLCHAIN}-gcc-ranlib" \
	NM="${FFBUILD_TOOLCHAIN}-gcc-nm" \
	CFLAGS="-static-libgcc -static-libstdc++ -I/opt/ffbuild/include -O2 -pipe -fPIC -DPIC -D_FORTIFY_SOURCE=2 -fstack-protector-strong -pthread" \
	CXXFLAGS="-static-libgcc -static-libstdc++ -I/opt/ffbuild/include -O2 -pipe -fPIC -DPIC -D_FORTIFY_SOURCE=2 -fstack-protector-strong -pthread" \
	LDFLAGS="-static-libgcc -static-libstdc++ -L/opt/ffbuild/lib -O2 -pipe -fstack-protector-strong -Wl,-z,relro,-z,now -pthread -lm" \
	STAGE_CFLAGS="-fvisibility=hidden -fno-semantic-interposition" \
	STAGE_CXXFLAGS="-fvisibility=hidden -fno-semantic-interposition"

[nyanmisaka]

@nyanmisaka why is all the building failing cause I don’t think the problem is coming from my PR or I missed something maybe I'm gonna look further when I'm home cause right now I don't have a pc for the week

I can build locally without your PR. Please check it on your side. I'll come back to this next time.

[Gauvino]

Your building with the script ?
What command do you use ?

[nyanmisaka]

./build focal arm64

[Gauvino]

I tried to build everything with different platform and the only problem I see was apt-transport-http being removed

[Gauvino]

@nyanmisaka Does this PR need changed or do you have a problem with it ?

If it is let me know it!

[nyanmisaka]

@nyanmisaka Does this PR need changed or do you have a problem with it ?

If it is let me know it!

I will take some time to test and will give you the results later.

[Gauvino]

@nyanmisaka Does this PR need changed or do you have a problem with it ?

If it is let me know it!

I will take some time to test and will give you the results later.

Could you at least approval the action check to see if it's building correctly please

[Gauvino]

Still failing don’t really know why but I will check when I’m back home

[Gauvino]

Could you please approval the action please @nyanmisaka

[Gauvino]

Another time could you please ! @nyanmisaka