use thought when calling to vfs for esoteric media

[KyleSanderson]

so I barely know python, but saw that there were massive stalls for populating the database with a very tiny media library. There's still some massive slowdown on series retrieval, but the episodes load in in about a second now from minutes previously. This results in a 7x performance improvement (time reduction) for library import overall, with about a 90x reduction on per-episode import.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
100.0% Duplication

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 21.07%. Comparing base (68c49ea) to head (df2e0d5).
Report is 260 commits behind head on master.

Files with missing lines	Patch %	Lines
jellyfin_kodi/objects/movies.py	0.00%	2 Missing ⚠️
jellyfin_kodi/objects/tvshows.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #766   +/-   ##
=======================================
  Coverage   21.07%   21.07%           
=======================================
  Files          63       63           
  Lines        8542     8542           
  Branches     1572     1572           
=======================================
  Hits         1800     1800           
  Misses       6726     6726           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[oddstr13]

You are making a bunch of duplicate logic here, I think it would make sense to move this check into the validate_*_dir functions (and probably just pass the obj in there for now).

TODO

• verify if validate_*_dir functions are also called from elsewhere

[mcarlton00]

Did some benchmarking here. Synced my entire movies and shows libraries from a fresh install on my main rig.

Current master: 4 minutes, 23 seconds
This PR: 4 minutes, 25 seconds

That's close enough I'd chalk it up to network speed variations, but also seems to indicate this is insignificant as far as speeding up the sync. It's possible this is only meaningful on lower power devices. Would need more investigating to say for sure.

[KyleSanderson]

Did some benchmarking here. Synced my entire movies and shows libraries from a fresh install on my main rig.

Current master: 4 minutes, 23 seconds This PR: 4 minutes, 25 seconds

That's close enough I'd chalk it up to network speed variations, but also seems to indicate this is insignificant as far as speeding up the sync. It's possible this is only meaningful on lower power devices. Would need more investigating to say for sure.

Add 50ms of latency between your Library and the client, or even 10ms.

[oddstr13]

This would in theory cut out two round-trips when adding items in native mode.

I'm not sure if Container is ever bluray or dvd, but I see that is checked elsewhere too.
Is that an API change, or did this never work?

Container isn't included in the toplevel item object when the media is BluRay or DVD (but an empty string in the MediaSources entries).

VideoType can have the value Dvd or BluRay however. It is VideoFile for mkv files.