Fix SessionStart double notifications #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a 5 second time gap between events to prevent the notification being sent twice. fixes jellyfin#269
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Corrected Nested 'if' statements.
crobibero
requested changes
Sep 4, 2024
…ctionary from growing
crobibero
reviewed
Sep 4, 2024
to prevent timer from initializing every time the SessionStartedEventArgs event is triggered
crobibero
reviewed
Sep 4, 2024
| @@ -26,6 +32,7 @@ public SessionStartNotifier( | |||
| { | |||
| _applicationHost = applicationHost; | |||
| _webhookSender = webhookSender; | |||
| _cleanupTimer?.Change(0, (int)TimeSpan.FromMinutes(30).TotalMilliseconds); | |||
There was a problem hiding this comment.
technically that line is redundant, just to avoid compiler warnings
Unused field '_cleanupTimer'CA1823
|
do you have a better solution or idea for this? |
|
I think it might be enough to clean up old cached sessions when a new SessionStart event is triggered so we don't need to have this timer thread running in the backround |
run cleanup when the event is triggered
crobibero
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 5 second time gap between events to prevent the notification being sent twice. fixes #269