Add basic av1 support to device profile #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
previously approved these changes
Sep 4, 2022
|
Believe it or not, this breaks av1 playback for me. Using a test file from here: https://www.elecard.com/videos It plays with Unstable (transcodes and plays). Using this PR, it errors out with the infamous "Content cannot be retrieved from server". |
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
|
This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add av1 to device profile so Roku devices which support av1 can direct play content.
More comprehensive detection and support is part of PR #686 by @whiteowl3, but this is a quick fix to address some user requests.
Changes