Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic av1 support to device profile #776

Closed
wants to merge 2 commits into from

Conversation

neilsb
Copy link
Member

@neilsb neilsb commented Sep 4, 2022

Add av1 to device profile so Roku devices which support av1 can direct play content.

More comprehensive detection and support is part of PR #686 by @whiteowl3, but this is a quick fix to address some user requests.

Changes

  • Add av1 support to device profile

@neilsb neilsb marked this pull request as draft September 4, 2022 11:14
@neilsb neilsb marked this pull request as ready for review September 4, 2022 11:24
crobibero
crobibero previously approved these changes Sep 4, 2022
@jimdogx
Copy link
Collaborator

jimdogx commented Sep 4, 2022

Believe it or not, this breaks av1 playback for me. Using a test file from here:

https://www.elecard.com/videos

It plays with Unstable (transcodes and plays). Using this PR, it errors out with the infamous "Content cannot be retrieved from server".

@github-actions
Copy link

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@github-actions github-actions bot added the stale This issue/PR has gone stale. label Sep 26, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired.

@github-actions github-actions bot closed this Oct 4, 2022
@neilsb neilsb mentioned this pull request Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue/PR has gone stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants