Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reworked video keyboard keys and fix osd visual #2013

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Reworked video keyboard keys and fix osd visual #2013

wants to merge 2 commits into from

Conversation

endrl
Copy link
Contributor

@endrl endrl commented May 17, 2023 •
edited
Loading

  • OSD: refactor: end time position uses now flex instead of <br/>
  • OSD: fixed: chars like g or q where cut at the bottom
  • OSD: fixed: "mouse move" overwrites no longer staticOverlay by starting the timer
  • OSD: feat: keyboard events show the osd
  • VideoPlayer: continous events for left/right key down

@jellyfin-bot jellyfin-bot added the vue Pull requests that edit or add Vue files label May 17, 2023
@ferferga
Copy link
Member

ferferga commented May 17, 2023 •
edited
Loading

@endrl Why this isn't part of #2001 and my requested changes?

@endrl
Copy link
Contributor Author

endrl commented May 17, 2023

Good question. The topic there was also compatibility with webos. For a better feedback i want to fork jellyfin-webos with patched jellyfin-vue and continue with final testing results.

This PR exists just because i am working on a new feature for jellyfin and better player control was required for testing, while i stumbled upon other things.

Out of curiosity. Am i the only one who can't use the mouse with the time slider? I found that <v-slider @start="" never emits and therefore never decouple from the player progress.

@ferferga
Copy link
Member

ferferga commented May 17, 2023 •
edited
Loading

@endrl Media keys are not exclusive to webOS according to the spec, so imo the key bindings from this PR could be merged to that one and leave the style fixes for this one.

Otherwise we scatter the context of the changes across multiple PRs + you'll need to fix conflicts more frequently.

Time slider working fine here, can you test with music too? Perhaps the issue is in the player's/hls side.

@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 26cf25b
Status 🔄 Deploying...
Preview URL Not available
Type 🔀 Preview

View bot logs

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jellyfin-bot jellyfin-bot added the merge conflict Something has merge conflicts label Aug 16, 2023
@ferferga ferferga force-pushed the master branch 2 times, most recently from bc856ac to 7336bfd Compare August 16, 2023 19:17
@ferferga ferferga force-pushed the master branch 2 times, most recently from f598745 to 00c2c75 Compare December 31, 2023 18:39
@ferferga ferferga force-pushed the master branch 8 times, most recently from 937e458 to 6c210e6 Compare April 16, 2024 08:57
@ferferga ferferga force-pushed the master branch 14 times, most recently from acb6ecf to 5d6a7c8 Compare August 11, 2024 11:13
@ferferga ferferga force-pushed the master branch 2 times, most recently from c360429 to f3260d9 Compare September 6, 2024 13:57
@ferferga ferferga force-pushed the master branch 9 times, most recently from fe041a3 to 3fbf550 Compare October 3, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge conflict Something has merge conflicts vue Pull requests that edit or add Vue files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endrl @ferferga @jellyfin-bot