Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tauri): http jellyfin server address #2050

Merged
merged 2 commits into from
Oct 1, 2023
Merged

fix(tauri): http jellyfin server address #2050

merged 2 commits into from
Oct 1, 2023

Conversation

endrl
Copy link
Contributor

@endrl endrl commented Jun 15, 2023

Disable https context.

Closes: #2009

prayag17
prayag17 reviewed Jun 16, 2023
View reviewed changes
Copy link

@prayag17 prayag17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use setup to create a new window, you can still use the older window created in tauri.conf.json, also you should disable the localhost server when in dev mode since vite already does that

@jellyfin-bot jellyfin-bot added the merge conflict Something has merge conflicts label Jun 19, 2023
@jellyfin-bot jellyfin-bot removed the merge conflict Something has merge conflicts label Jun 20, 2023
@endrl
Copy link
Contributor Author

endrl commented Jun 20, 2023

Updated, also added save/restore of window state which is probably more convenient

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ferferga ferferga force-pushed the master branch 2 times, most recently from bc856ac to 7336bfd Compare August 16, 2023 19:17
@jellyfin-bot jellyfin-bot added the merge conflict Something has merge conflicts label Sep 1, 2023
@endrl
Copy link
Contributor Author

endrl commented Sep 27, 2023

Tauri merged a new option to enable http for windows. This supersedes the localhost plugin. tauri-apps/tauri#7645

@ferferga
Copy link
Member

@endrl That's great news! As soon as I see a Tauri update from renovate I'll merge so you can update this PR accordingly :)

@endrl endrl closed this Sep 27, 2023
@endrl endrl reopened this Sep 27, 2023
@jellyfin-bot jellyfin-bot removed the merge conflict Something has merge conflicts label Sep 27, 2023
@endrl
Copy link
Contributor Author

endrl commented Sep 27, 2023

Added a patch which points to WIP Tauri 1.5. If you want to wait for Tauri 1.5 release, we can close this PR - no changes required :)

@ferferga
Copy link
Member

ferferga commented Sep 28, 2023 •
edited
Loading

@endrl Can you try the artifacts of #2096 and let me know if merging that PR fixes this?
@prayag17 Your input is welcome too!

Since the fix is Windows-only, what happens with other OSes?

@prayag17
Copy link

I will have to check if their fix works on Linux before merging it.

@endrl
Copy link
Contributor Author

endrl commented Sep 29, 2023

Oh, already released. That's fast.

I installed the deb and i noticed:

  • App Icon is not available
  • Loading screen loops endless. It might be the CSP (console is not enabled!)

So we are back at: #2049

@ferferga
Copy link
Member

@endrl But it's the original issue that ti's PR was addressing solved?

@endrl
Copy link
Contributor Author

endrl commented Sep 29, 2023

Oh, there is missing flag. Now it's working. You can merge this and update to tauri 1.5

ferferga
ferferga reviewed Sep 30, 2023
View reviewed changes
tauri/tauri.conf.json Outdated Show resolved Hide resolved
@ferferga
Copy link
Member

ferferga commented Sep 30, 2023 •
edited
Loading

@endrl The checks are still failing for some reason

@ferferga
Copy link
Member

ferferga commented Oct 1, 2023

@endrl Oops, good catch! Let's rerun checks after the renovate PR.

@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ferferga ferferga merged commit 323d0a8 into jellyfin:master Oct 1, 2023
15 of 18 checks passed
@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 604654b
Status ✅ Deployed!
Preview URL https://d71c48fe.jf-vue.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@endrl endrl deleted the tauri_http branch October 19, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferferga ferferga ferferga approved these changes

@prayag17 prayag17 prayag17 left review comments

Assignees
No one assigned
Labels
None yet
Projects
Ongoing development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tauri app won't accept HTTP server url
4 participants
@endrl @ferferga @prayag17 @jellyfin-bot