remove black bar from trickplay images fixes #6404 #6572
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
|
|
How about light shots/scenes? |
or we can add black boarder to text as even at any level of opacity the whole box that almost covers half of image is unnecessary. if we agree on this approach i will update the PR. or we can copy current youtube behavior?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement : Remove black bar from trickplay images fixes #6404
Changes
in this Pr we are chaning the container chapterThumbTextContainer to not show any background for trickplay text. so that black bar that covers signifiacant amount of the image can be removed
Issues
fixes #6404