-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security upgrades #203
Open
euanmillar
wants to merge
25
commits into
master
Choose a base branch
from
security-upgrades
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Security upgrades #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main issue which was preventing hearth from building was in libxmljs->nan and it was fixed in nan >= 2.8.0 which is used in libxmljs >= 0.18.8
Some tests fail if the tests run in parallel.
Tar is a dependency of libxmljs->node-pre-gyp and libxmljs is already at the latest version that is currently available. Furthermore, node-pre-gyp is now deprecated so had to add resolution directly for tar.
21 tasks
rikukissa
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies with Critical vulnerabilities:
Dependencies with High vulnerabilities:
Dependencies with Moderate vulnerabilities:
Node engine limitation
Previously hearth was limited to using node >= 6.9.0 and < 9.0.0 because using anything newer
would cause the build process to fail. The issue was actually with fhir->libxmljs->nan and using
libxmljs >= 0.18.8 made it possible to remove the engine limitation.
Now it works with node v14.18.1