Add utf-8 encoding on dhis2 endpoint: this resolve bad request error on win platform #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mks-d
reviewed
Jan 9, 2019
| @@ -212,7 +213,7 @@ private void saveToBackUp(String path, String jsonResponse) { | |||
| } | |||
|
|
|||
| String directoryStructure = OpenmrsUtil.getApplicationDataDirectory() + DHISCONNECTOR_DHIS2BACKUP_FOLDER | |||
| + path.substring(0, path.lastIndexOf(File.separator)); | |||
| + path.substring(0, path.lastIndexOf(File.separator) == -1? path.length() - 1 :path.lastIndexOf(File.separator)); | |||
There was a problem hiding this comment.
@ahammi maybe this?
import java.nio.file.Paths;
Paths.get(OpenmrsUtil.getApplicationDataDirectory(), DHISCONNECTOR_DHIS2BACKUP_FOLDER, path)
.toString()
There was a problem hiding this comment.
looks like that looks better if tested to work
There was a problem hiding this comment.
@kaweesi yes this a vetted Java lib that is working fine, please try it out :-)
Example:
System.out.println( Paths.get("/path/to", "some", "/place", "somewhere/").toString() );
kaweesi
suggested changes
Jan 10, 2019
| DefaultHttpClient client = null; | ||
| String payload = ""; | ||
|
|
||
| if (StringUtils.isNotBlank(endpoint)) { | ||
| try { | ||
| if( endpoint.contains("fields=") ) { |
There was a problem hiding this comment.
i see some trailing spaces, rightly format the code to remove such spaces like after 'if(' and before ') {'
| @@ -212,7 +213,7 @@ private void saveToBackUp(String path, String jsonResponse) { | |||
| } | |||
|
|
|||
| String directoryStructure = OpenmrsUtil.getApplicationDataDirectory() + DHISCONNECTOR_DHIS2BACKUP_FOLDER | |||
| + path.substring(0, path.lastIndexOf(File.separator)); | |||
| + path.substring(0, path.lastIndexOf(File.separator) == -1? path.length() - 1 :path.lastIndexOf(File.separator)); | |||
There was a problem hiding this comment.
looks like that looks better if tested to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utf-8 encoding on dhis2 endpoint: this resolve bad request error on win platform