Add Custom Location Mapping feature: it allows to run automated reports for multiples Location/OrgUni mapping. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 9, 2019 18:53
…ts for multiples Location/OrgUni mapping.
kaweesi
suggested changes
Jan 10, 2019
| try { | ||
| if (!mappingsDirecory.mkdirs()) { | ||
| log.warn("Not able to create resource folder"); | ||
| }else{ |
There was a problem hiding this comment.
some right code format needed here too, '}else'
There was a problem hiding this comment.
fixed - please see my last commit
| }else{ | ||
| File directory = new File(getClass().getClassLoader().getResource("mappings").getFile()); | ||
| FileUtils.copyDirectory(directory, mappingsDirecory); | ||
| log.debug("Copiyed all the mapping files to:"+mappingsDirecory); |
There was a problem hiding this comment.
fixed - please see my last commit
| @@ -64,6 +67,8 @@ | |||
| public static final String GLOBAL_PROPERTY_USER = "dhisconnector.user"; | |||
|
|
|||
| public static final String GLOBAL_PROPERTY_PASS = "dhisconnector.pass"; | |||
|
|
|||
| public static final String GLOBAL_PROPERTY_FULL_MAPPING = "dhisconnector.fullmappingvalues"; | |||
There was a problem hiding this comment.
why not initialise this in config.xml, better you even have it in one place and reference it from there where else you need it
There was a problem hiding this comment.
I wanted to be coherent with the other codes (user and password preoperties)
There was a problem hiding this comment.
those (user & pass) are initialised in config.xml
|
I added new menu called Custom Location Mapping. It allows to predefine a list of mapping between locations and OrgUnits : That custom mapping can be used within Automation menu, so the reports is runned for all predefined mappings at once: I hope I was clear. Thanks for your time |
|
great, i will find time as soon as i can to do a more detailed review and
testing.
thanks
…On Fri, Jan 18, 2019 at 10:57 AM ahammi ***@***.***> wrote:
I added new menu called Custom Location Mapping. It allows to predefine a
list of mapping between locations and OrgUnits :
[image: image]
<https://user-images.githubusercontent.com/45977120/51372778-95dfd380-1afe-11e9-9ca6-0f8c2d7df36c.png>
That custom mapping can be used within Automation menu, so the reports is
runned for all predefined mappings at once:
[image: image]
<https://user-images.githubusercontent.com/45977120/51372670-397cb400-1afe-11e9-857b-5d689728f1b6.png>
I hope I was clear. Thanks for your time
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APJk8huXVdS4aKfjb_ypj0rg89It-1v9ks5vEX5-gaJpZM4Z4AEM>
.
--
*Kaweesi Joseph*
*Jembi Health Systems NPC* *| **Uganda*
*Mobile: **+256784994313** | Office: **Software Developer** | Skype:*
*kaweesi.joseph*
*E-mail: [email protected] <[email protected]>*
*This e-mail contains proprietary and confidential information some or all
of which may be legally privileged. It is for the intended recipient only.
If an addressing or transmission error has misdirected this e-mail, please
notify the author by replying to this e-mail and then deleting same. If you
are not the intended recipient you must not use, disclose, distribute,
copy, print or rely on this e-mail. Jembi Health Systems NPO, its
subsidiaries and associated companies is not liable for the security of
information sent by e-mail and accepts no liability of whatsoever nature
for any loss, damage or expense resulting, directly or indirectly, from the
access of this e-mail or any attachments hereto.*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Custom Location Mapping feature: it allows to run automated reports for multiples Location/OrgUni mapping.