Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github app support to incrementals #80

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Add github app support to incrementals #80

merged 1 commit into from
Jan 13, 2022

Conversation

timja
Copy link
Member

@timja timja commented Jan 12, 2022

@timja timja requested review from halkeye and dduportal January 12, 2022 22:19
@halkeye
Copy link
Member

halkeye commented Jan 12, 2022

don't you need to update image: too?

@timja
Copy link
Member Author

timja commented Jan 12, 2022

don't you need to update image: too?

update cli will do that post merge, I'm making this backwards compatible so chart and image are independent

@halkeye
Copy link
Member

halkeye commented Jan 12, 2022

ah okay okay

lgtm

@timja timja merged commit 7d050f7 into jenkins-infra:main Jan 13, 2022
@timja timja deleted the add-github-app-support branch January 13, 2022 07:49
lemeurherve pushed a commit to lemeurherve/helm-charts that referenced this pull request Jan 13, 2022
@timja @lemeurherveCB
Add github app support to incrementals (jenkins-infra#80)
e299b29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halkeye halkeye halkeye approved these changes

@dduportal dduportal Awaiting requested review from dduportal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timja @halkeye