feat: Add hover effect to Navbar links #145
Conversation
src/jio-navbar.css
Outdated
| @@ -104,19 +104,27 @@ button:not(:disabled) { | |||
| line-height: inherit; | |||
| margin: 0 auto; | |||
| } | |||
| /* .nav-link.dropdown-toggle:hover { | |||
There was a problem hiding this comment.
What's the purpose of all this commented out code?
src/jio-navbar.css
Outdated
|
|
||
| button.nav-link { | ||
| background: #f9f9f9; | ||
| border: 1px solid #ccc; | ||
| border-radius: 3px; | ||
| box-shadow: 0 2px 4px -3px rgb(0 0 0 / 25%); | ||
| } | ||
|
|
||
| .nav-link:hover{ | ||
| button.nav-link:hover { |
There was a problem hiding this comment.
Is there a reason you are specifically targetting buttons now?
|
@halkeye The PR was incomplete. It is complete now. I can't understand the reason for this linting error. |
does line 107 on jio-navbar.css have a empty line before the next rule? |
@halkeye Made the appropriate changes. |
|
I'll admit, i'm not sure why a hover effect is wanted. Have you talked to any of the sig leaders about it? like @MarkEWaite or @kmartens27 ? |
|
No, but I was working with the Navbar component when I noticed that it is very easy to click another link when there is no difference on hover. |
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added hover effect to Navbar links.
Before:
After:
Fixes #144