Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-58743] Document new system properties for DefaultConfidentialStore #7859

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

Vlatombe
Copy link
Contributor

User-facing documentation for jenkinsci/jenkins#10235

@Vlatombe Vlatombe requested a review from a team as a code owner February 10, 2025 08:51
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label Feb 10, 2025
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Vincent! 👍

@gounthar gounthar enabled auto-merge (squash) February 10, 2025 09:02
@gounthar gounthar merged commit a8ec220 into jenkins-infra:master Feb 10, 2025
4 of 6 checks passed
@jglick
Copy link
Contributor

jglick commented Feb 10, 2025

FWIW this system seems really wrong. If we want a complete, accurate list of system properties (encompassing both core and plugins), we should instead define them as constants with a special annotation, and then use an annotation processor to summarize defined properties into a static file in the JAR, then load these files from the current enabled versions of core & plugins and display them in a live page under Manage Jenkins. (You could also record actual calls to SystemProperties though this would then fail to display properties which for whatever reason had not yet been checked in the current session.) Compare about:config in Firefox or chrome://flags/, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants