Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linux installation instructions update #3671

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

mbergo
Copy link
Contributor

@mbergo mbergo commented Nov 11, 2022

This fixes the current way of install Jenkins X on Linux, working with Fedora 37 and ZSH

Signed-off-by: Marcus Bergo [email protected]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist:

  • I have mentioned the appropriate type(scope), as referenced here in the commit message and PR title for the semantic checks to pass.
  • I have signed off the commit, as per instructions mentioned here.
  • Any dependent changes have already been merged.

/assign @rawlingsj

This fixes the current way of install Jenkins X on Linux, working with Fedora 37 and ZSH

Signed-off-by: Marcus Bergo <[email protected]>
@jenkins-x-bot
Copy link
Contributor

Hi @mbergo. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mbergo
Copy link
Contributor Author

mbergo commented Nov 11, 2022

/assign @rawlingsj

@babadofar
Copy link
Contributor

/ok-to-test

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3671 here

@ankitm123
Copy link
Member

/hold

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3671 here

@tomhobson
Copy link
Member

/hold cancel
/approve

@tomhobson
Copy link
Member

fixes: #3699

Copy link
Member

@tomhobson tomhobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@tomhobson
Copy link
Member

/retest

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3671 here

@jenkins-x-bot jenkins-x-bot merged commit d2aa655 into jenkins-x:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants