fix: allow templated values in podAnnotations

[roulettedares]

I have a use case to use dynamic values in .Values.podAnnotations. I'd imagine other folks will eventually encounter something similar.

values.yaml:

# Add annotations to the pods
podAnnotations:
  vault.security.banzaicloud.io/vault-agent-configmap: '{{ template "fullname" . }}-configs'

[jenkins-x-bot]

Hi @joshuasimon-taulia. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[roulettedares]

how does the CI work on this btw? do i need to manually add my changes to all of the charts in the packs folder or does jx gitops upgrade run after merge?

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign babadofar
You can assign the PR to them by writing /assign @babadofar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[msvticket]

how does the CI work on this btw? do i need to manually add my changes to all of the charts in the packs folder or does jx gitops upgrade run after merge?

It's not run automatically

[msvticket]

how does the CI work on this btw? do i need to manually add my changes to all of the charts in the packs folder or does jx gitops upgrade run after merge?

It's not run automatically

So if you want the change on all deployment templates you need to push that yourself.

[msvticket]

@ joshuasimon-taulia will you continue with this PR?

[roulettedares]

yeah, give me a couple of days

[msvticket]

yeah, give me a couple of days

Quite a lot of days has passed now... 😉