Fixing spotbugs findings (#116)

pom.xml

@@ -18,6 +18,8 @@
     <revision>0.7.25</revision>
     <changelist>-SNAPSHOT</changelist>
     <jenkins.version>2.361</jenkins.version>
+    <spotbugs.effort>Max</spotbugs.effort>
+    <spotbugs.threshold>Low</spotbugs.threshold>
   </properties>
 
   <developers>

src/main/java/hudson/plugins/accurev/AccurevChangeLogSet.java

@@ -46,7 +46,7 @@ public Collection<AccurevTransaction> getLogs() {
 
   public java.lang.Object[] toArray() {
     if (transactions == null) {
-      return null;
+      return new java.lang.Object[0];
     }
 
     return transactions.toArray();

src/main/java/hudson/plugins/accurev/AccurevLauncher.java

@@ -343,35 +343,24 @@ public static <TResult, TContext> TResult runCommand( //
           directoryToRunCommandFrom,
           loggerToLogFailuresTo,
           listenerToLogFailuresTo);
-      try {
-        final int commandExitCode =
-            runCommandToCompletion(starter, synchronizationLockObjectOrNull);
-        final InputStream outputFromCommand = stdout.getInput();
-        final InputStream errorFromCommand = stderr.getInput();
-        if (commandExitCode != 0) {
-          logCommandFailure(
-              machineReadableCommand,
-              directoryToRunCommandFrom,
-              humanReadableCommandName,
-              commandExitCode,
-              outputFromCommand,
-              errorFromCommand,
-              loggerToLogFailuresTo,
-              listenerToLogFailuresTo);
-          return null;
-        }
-        return commandOutputParser.parse(outputFromCommand, commandOutputParserContext);
-      } catch (Exception ex) {
-        logCommandException(
+
+      final int commandExitCode = runCommandToCompletion(starter, synchronizationLockObjectOrNull);
+      final InputStream outputFromCommand = stdout.getInput();
+      final InputStream errorFromCommand = stderr.getInput();
+      if (commandExitCode != 0) {
+        logCommandFailure(
             machineReadableCommand,
             directoryToRunCommandFrom,
             humanReadableCommandName,
-            ex,
+            commandExitCode,
+            outputFromCommand,
+            errorFromCommand,
             loggerToLogFailuresTo,
             listenerToLogFailuresTo);
         return null;
       }
-    } catch (InterruptedException | IOException ex) {
+      return commandOutputParser.parse(outputFromCommand, commandOutputParserContext);
+    } catch (InterruptedException | IOException | UnhandledAccurevCommandOutput ex) {
       logCommandException(
           machineReadableCommand,
           directoryToRunCommandFrom,

src/main/java/hudson/plugins/accurev/AccurevReferenceTree.java

@@ -10,6 +10,7 @@ public class AccurevReferenceTree implements Serializable {
   private final String host;
   private final String storage;
   private AccurevStream stream = null;
+  private static final long serialVersionUID = 1L;
 
   public AccurevReferenceTree(
       String depot, Long streamNumber, String name, String host, String storage) {

src/main/java/hudson/plugins/accurev/AccurevSCM.java

@@ -566,7 +566,7 @@ public String getPollingStream(Job<?, ?> project, TaskListener listener)
 
   @Extension
   @Symbol("accurev")
-  public static class AccurevSCMDescriptor extends SCMDescriptor<AccurevSCM>
+  public static final class AccurevSCMDescriptor extends SCMDescriptor<AccurevSCM>
       implements ModelObject {
 
     private static final Logger DESCRIPTORLOGGER =
@@ -1014,7 +1014,7 @@ public DescriptorImpl getDescriptor() {
 
     @Extension
     @Symbol("accurevServer")
-    public static class DescriptorImpl extends Descriptor<AccurevServer> {
+    public static final class DescriptorImpl extends Descriptor<AccurevServer> {
 
       public DescriptorImpl() {
         load();

src/main/java/hudson/plugins/accurev/AccurevTransaction.java

@@ -1,5 +1,6 @@
 package hudson.plugins.accurev;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.model.User;
 import hudson.scm.ChangeLogSet;
 import hudson.scm.EditType;
@@ -92,6 +93,9 @@ public Collection<String> getFileRevisions() {
   }
 
   @Exported
+  @SuppressFBWarnings(
+      value = "UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR",
+      justification = "We hope that AccurevTransaction.author is not null here...  Need to fix.")
   public String getUser() { // digester wants read/write property, even though it never reads. Duh.
     return author.getDisplayName();
   }
@@ -101,6 +105,9 @@ public void setUser(String author) {
   }
 
   @Exported
+  @SuppressFBWarnings(
+      value = "UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR",
+      justification = "We hope that AccurevTransaction.date is not null here...  Need to fix.")
   public Date getDate() {
     return (Date) date.clone();
   }
@@ -123,6 +130,9 @@ protected void setParent(ChangeLogSet parent) {
   }
 
   @Exported
+  @SuppressFBWarnings(
+      value = "UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR",
+      justification = "We hope that AccurevTransaction.action is not null here...  Need to fix.")
   public EditType getEditType() {
     if (action.equals("promote")) {
       return EditType.EDIT;

src/main/java/hudson/plugins/accurev/AccurevWorkspace.java

@@ -16,6 +16,7 @@ public class AccurevWorkspace implements Serializable {
   private final String host;
   private final String storage;
   private AccurevStream stream = null;
+  private static final long serialVersionUID = 1L;
 
   public AccurevWorkspace(
       String depot, Long streamNumber, String name, String host, String storage) {

src/main/java/hudson/plugins/accurev/CheckForChanges.java

@@ -148,7 +148,7 @@ public static boolean checkStreamForChanges(
                 stream.getName(),
                 transactionTypes,
                 dateRange);
-        if (null != tempTransaction && !tempTransaction.isEmpty()) {
+        if (!tempTransaction.isEmpty()) {
           for (AccurevTransaction t : tempTransaction) {
             if (t.getAffectedPaths().isEmpty()
                 && (t.getAction().equals("mkstream")

src/main/java/hudson/plugins/accurev/DetermineRemoteHostname.java

@@ -11,6 +11,7 @@ public class DetermineRemoteHostname
     implements Callable<RemoteWorkspaceDetails, UnknownHostException> {
 
   private final String path;
+  private static final long serialVersionUID = 1L;
 
   public DetermineRemoteHostname(String path) {
     this.path = path;

src/main/java/hudson/plugins/accurev/GetConfigWebURL.java

@@ -5,6 +5,7 @@
 public class GetConfigWebURL implements Serializable {
 
   private final String webURL;
+  private static final long serialVersionUID = 1L;
 
   public GetConfigWebURL(String webURL) {
     this.webURL = webURL;

src/main/java/hudson/plugins/accurev/RefTreeExternalFile.java

@@ -6,6 +6,7 @@ public class RefTreeExternalFile implements Serializable {
 
   private final String location;
   private final String status;
+  private static final long serialVersionUID = 1L;
 
   public RefTreeExternalFile(String location, String status) {
     this.location = location;

src/main/java/hudson/plugins/accurev/RemoteWorkspaceDetails.java

@@ -8,6 +8,7 @@ public class RemoteWorkspaceDetails implements Serializable {
   private final String hostName;
   private final String path;
   private final String fileSeparator;
+  private static final long serialVersionUID = 1L;
 
   public RemoteWorkspaceDetails(String hostName, String path) {
     this.hostName = hostName;

src/main/java/hudson/plugins/accurev/delegates/ReftreeDelegate.java

@@ -35,7 +35,7 @@ public ReftreeDelegate(AccurevSCM scm) {
     super(scm);
   }
 
-  public String getRefTree() {
+  public String getSCMRefTree() {
     return scm.getReftree();
   }
 
@@ -49,7 +49,7 @@ protected PollingResult checkForChanges(Job<?, ?> project)
         return PollingResult.BUILD_NOW;
       } else {
         if (Update.hasChanges(
-            scm, server, accurevEnv, accurevWorkingSpace, listener, launcher, getRefTree())) {
+            scm, server, accurevEnv, accurevWorkingSpace, listener, launcher, getSCMRefTree())) {
           return PollingResult.BUILD_NOW;
         } else {
           return PollingResult.NO_CHANGES;
@@ -164,7 +164,7 @@ private boolean doUpdate(File changeLogFile) throws IOException {
         accurevWorkingSpace,
         listener,
         launcher,
-        getRefTree(),
+        getSCMRefTree(),
         updateLogFile);
   }
 
@@ -209,12 +209,12 @@ protected ArgumentListBuilder getRelocateCommand() {
     chrefcmd.add("chref");
     Command.addServer(chrefcmd, server);
     chrefcmd.add("-r");
-    chrefcmd.add(getRefTree());
+    chrefcmd.add(getSCMRefTree());
     return chrefcmd;
   }
 
   protected boolean validateCheckout(Run<?, ?> build) {
-    String reftree = getRefTree();
+    String reftree = getSCMRefTree();
     if (StringUtils.isEmpty(reftree)) {
       listener.fatalError("Must specify a reference tree");
       return false;

src/main/java/hudson/plugins/accurev/delegates/WorkspaceDelegate.java

@@ -33,7 +33,7 @@ public WorkspaceDelegate(AccurevSCM scm) {
   }
 
   @Override
-  public String getRefTree() {
+  public String getSCMRefTree() {
     return null;
   }
 

src/main/java/jenkins/plugins/accurev/AccurevTool.java

@@ -30,7 +30,7 @@
 public class AccurevTool extends ToolInstallation
     implements NodeSpecific<AccurevTool>, EnvironmentSpecific<AccurevTool> {
 
-  public static final transient String DEFAULT = "Default";
+  private static final String DEFAULT = "Default";
   private static final long serialVersionUID = 1;
   private static final Logger LOGGER = Logger.getLogger(AccurevTool.class.getName());
 
@@ -118,7 +118,7 @@ public DescriptorImpl getDescriptor() {
 
   @Extension
   @Symbol("accurevTool")
-  public static class DescriptorImpl extends ToolDescriptor<AccurevTool> {
+  public static final class DescriptorImpl extends ToolDescriptor<AccurevTool> {
 
     public DescriptorImpl() {
       super();