-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor type: make the report aware of parser properties #1111
Conversation
☀️ Quality Monitor 🚦 Tests: 100% successful (❌ 2 failed, ✔️ 1291 passed, 🙈 2 skipped) 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
src/main/java/edu/hm/hafner/analysis/parser/checkstyle/CheckStyleParser.java
Fixed
Show fixed
Hide fixed
☀️ Quality Monitor 🚦 Tests: 100% successful (❌ 2 failed, ✔️ 1292 passed, 🙈 2 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
* @throws ParsingException | ||
* due to digester.parse(new InputSource(source)) | ||
*/ | ||
JcReport createReport(final ReaderFactory readerFactory) |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
src/main/java/edu/hm/hafner/analysis/parser/checkstyle/CheckStyleParser.java
Fixed
Show fixed
Hide fixed
☀️ Quality Monitor 🚦 Tests: 100% successful (✔️ 1298 passed, 🙈 2 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
@@ -67,7 +67,7 @@ | |||
} | |||
|
|||
@Override | |||
public Report parse(final ReaderFactory readerFactory) throws ParsingCanceledException, ParsingException { | |||
public Report parseReport(final ReaderFactory readerFactory) throws ParsingCanceledException, ParsingException { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
private static final long serialVersionUID = -3187275729854832128L; | ||
|
||
@Override | ||
public Report parseReport(final ReaderFactory readerFactory) throws ParsingException { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
} | ||
|
||
@Override | ||
public void end(final String namespace, final String name) |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
} | ||
|
||
@Override | ||
protected void configureParser(final Digester digester) { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
} | ||
|
||
@Override | ||
protected void configureParser(final Digester digester) { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
return issues; | ||
} | ||
|
||
private Report parseIssues(final ReaderFactory readerFactory) { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
} | ||
} | ||
|
||
private Report parseErrors(final ReaderFactory readerFactory) { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
} | ||
|
||
@Override | ||
protected void configureParser(final Digester digester) { |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Potentially unsafe classes Warning
org.apache.commons.digester3.Digester
☀️ Quality Monitor 🚦 Tests: 100% successful (✔️ 1298 passed, 🙈 2 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: 100% successful (✔️ 1298 passed, 🙈 2 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: No test results available 🚧 Error Messages
Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: 100% successful (✔️ 1273 passed, 🙈 2 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: 100% successful (✔️ 1273 passed, 🙈 2 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
☀️ Quality Monitor 🚦 Tests: 100% successful (✔️ 1273 passed, 🙈 2 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
Make some additional properties available in the serialization of a report: