Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issue update-readme #231

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

vishalhcl-5960
Copy link
Collaborator

Listed a known issue in the readme file.

Copy link
Contributor

@mattmurp mattmurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this message more clear. It's confusing as written, since users may not know what we mean by "Git repository scan". Something like:

"Scans created using the "Scan GitHub repository" feature in the AppScan on Cloud web interface are not supported for rescan in the Jenkins Plugin."

We should add a note about the error that will be seen if this is done and what will happen (i.e. the build will not fail and the results from the last run will be shown).

@vishalhcl-5960
Copy link
Collaborator Author

We should make this message more clear. It's confusing as written, since users may not know what we mean by "Git repository scan". Something like:

"Scans created using the "Scan GitHub repository" feature in the AppScan on Cloud web interface are not supported for rescan in the Jenkins Plugin."

We should add a note about the error that will be seen if this is done and what will happen (i.e. the build will not fail and the results from the last run will be shown).

Sure, Made the changes accordingly.

@vishalhcl-5960 vishalhcl-5960 merged commit 1719753 into master Oct 1, 2024
3 checks passed
@vishalhcl-5960 vishalhcl-5960 deleted the Known-issue-update-Readme branch October 1, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants