Fixed ssh private key format issue #317
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue - #299
As per the issue, the ssh private keys are in an invalid format coming from the AWS Secrets Manager. I have tried it on both Windows and Linux worker nodes and a Linux Jenkins server and the issue exists on all of them. The change suggested in this PR fixes the carriage returns so the ssh private key format is valid. I have modified the StringSupplier, as that is only used for the sshUserPrivateKey option.
Testing done
AWS Secret:
Before:
1. Jenkins can't access github using the private key:
2. When the file is taken down onto a node, it has an invalid format:
You can see the ^M in the editor
After:
1. Jenkins has access to github using the private key:
Other secrets work as expected
Username and password:
Secret string:
Submitter checklist