Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabs in 2.496 #376

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix tabs in 2.496 #376

merged 2 commits into from
Feb 24, 2025

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Feb 24, 2025

Bootstrap tabs have different markup in comparison to tabs in core. This led to a regression in plugins that use Bootstrap 5 when jenkinsci/jenkins#10198 was merged. The markup in core should probably be updated to align with how Bootstrap does it, seeing as that seems to be more semantically correct (but that'd be a much larger change).

Before
image

After
image

Unsure if we want to release for 2.496 and above now, or wait for the next LTS @uhafner

Testing done

  • Coverage report works as expected

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik janfaracik marked this pull request as draft February 24, 2025 10:36
@uhafner uhafner added the bug Bugs or performance problems label Feb 24, 2025
@uhafner
Copy link
Member

uhafner commented Feb 24, 2025

I think it makes sense to release a version that contains in the POM

<jenkins.version>2.496</jenkins.version>

Then everybody on weekly gets these changes right now.

@uhafner
Copy link
Member

uhafner commented Feb 24, 2025

I tried it locally now and the selection works again! Thanks for fixing.

One thing that is still different to the LTS: In multiline mode the tabs container has a half-sized circle as a border while in LTS this is a rectangle with rounded borders.

Bildschirmfoto 2025-02-24 um 13 20 19

Is there one property missing? (Left is new, right is LTS).

This leads to:

Bildschirmfoto 2025-02-24 um 13 23 39

@janfaracik janfaracik marked this pull request as ready for review February 24, 2025 13:44
@janfaracik
Copy link
Contributor Author

I tried it locally now and the selection works again! Thanks for fixing.

No worries :)

One thing that is still different to the LTS: In multiline mode the tabs container has a half-sized circle as a border while in LTS this is a rectangle with rounded borders.

Bildschirmfoto 2025-02-24 um 13 20 19

Is there one property missing? (Left is new, right is LTS).

This leads to:

Bildschirmfoto 2025-02-24 um 13 23 39

That should be fixed in the next weekly - it's just been recently merged jenkinsci/jenkins#10312

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@uhafner uhafner merged commit 86265b3 into jenkinsci:main Feb 24, 2025
28 checks passed
@janfaracik janfaracik deleted the fix-tabs branch February 24, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants