Pull Request: Choose status which abort the flow build #67
Conversation
ueberhammDesign
force-pushed
the
chooseStatusPR
branch
from
88d6a5e
to
bfcd047
Compare
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| @@ -91,6 +78,30 @@ abstract class DSLTestCase extends HudsonTestCase { | |||
| return flow.scheduleBuild2(0).get() | |||
| } | |||
|
|
|||
| def runWithAbortWhenWorseThanSuccess = { script -> | |||
There was a problem hiding this comment.
please refactor, I think you only need one method runWithAbortWhenWorseThan { script, abortWhenWorseThan -> ... }
ueberhammDesign
force-pushed
the
chooseStatusPR
branch
from
4ab03a2
to
4de406d
Compare
ueberhammDesign
force-pushed
the
chooseStatusPR
branch
from
dd8b879
to
352ca26
Compare
|
New testcases added. |
|
Since I am currently looking for someone else to take over as a maintainer; I will not be the one merging this change. Please check http://jenkins-ci.org/pull-request-greeting. Side note: I think introducing new features in this plugin is risky and takes away resources that could be better spent on the pipeline plugin. However, please feel free to merge if you are interested in carrying on the flag. I did look at your changes though, and thank you for addressing my earlier concerns. |
Reopen Pull-Request #59 to squash all together and resolve merge problems.
Original Message:
You can choose the status (Success, Unstable or Failure), which abort the flow build. It also contains, that the build can not be 'better' than any build inside the flow build.