Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix JENKINS-46940 by preventing entries having the same project name from being added more than once #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dliakh
Copy link

@dliakh dliakh commented Jul 1, 2021

JENKINS-46940

In addition to the duplicate protection added earlier (that didn't work for some reason)
also prevent duplicates by checking whether there is an entry having the same project name already.
(Tested on the local Jenkins setup which had an issue with duplicated before the change and doesn't have it after)
Please, can you check whether this technique (preventing duplicates based on the name of the project associated with the entry)
is ok

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dliakh
Copy link
Author

dliakh commented Jul 2, 2021

Well, need to recheck how that affect [possible] cases of having multiple projects with the same name
(is that possible when using Jenkins' "folders", for example?)

@akrapfl
Copy link

akrapfl commented Feb 9, 2022

Wonder what the checks failure means, and if it happened before this PR.

@dliakh I haven't looked at your changes yet, but I'd like to test this. In response to your concerns over side effects, I wonder if it would be possible to add a configuration flag somewhere to make the deduplicating behavior optional. Defaults to off, and turn it on if you want that correction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants