Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74054] Extract inline script block in AbstractNameValueHeader/rowHeader.jelly #147

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+8 −8
Open

[JENKINS-74054] Extract inline script block in AbstractNameValueHeader/rowHeader.jelly #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b65fcf0
extract inline script in
shlomomdahan Oct 31, 2024
5b073d9
extract inline script in
shlomomdahan Oct 31, 2024
c649a4c
extract inline script in
shlomomdahan Oct 31, 2024
7fb5e63
Merge branch 'master' into JENKINS-74054
shlomomdahan Nov 8, 2024
e369daf
remove redundant class
shlomomdahan Nov 8, 2024
f3408d8
remove redundant class
shlomomdahan Nov 8, 2024
321ecdf
Merge branch 'master' into JENKINS-74054
shlomomdahan Nov 8, 2024
65fa4b9
Merge branch 'master' into JENKINS-74054
shlomomdahan Nov 8, 2024
865f3a6
Update build-parameters-tooltip.js
shlomomdahan Nov 10, 2024
7d759f1
remove redundant ID. Show tooltip when hovering card body
shlomomdahan Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/build-parameters-tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
const buildId = document.querySelector('.pipeline-info .revision .title').dataset.buildId;
jQuery('#build-parameters-' + buildId).tooltip({
shlomomdahan marked this conversation as resolved.
Show resolved Hide resolved
bodyHandler: function() {
return jQuery('#build-parameters-' + buildId).html();
},
});
10 changes: 2 additions & 8 deletions ...trumsystems/hudson/plugin/buildpipeline/extension/AbstractNameValueHeader/rowHeader.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<div class="pipeline-info">
<div class="revision rounded">
<div class="title">Pipeline ${buildGrid.get(0,0).getRevision()}</div>
<div class="title" data-build-id="${buildGrid.get(0,0).getId()}">Pipeline ${buildGrid.get(0,0).getRevision()}</div>
<j:choose>
<j:when test="${buildGrid.get(0,0).getParameters().isEmpty()}">
<div class="description">No parameters</div>
Expand All @@ -21,13 +21,7 @@
</j:forEach>
</ul>
</div>
<script>
jQuery('#build-parameters-trigger-${buildGrid.get(0,0).getId()}').tooltip({
bodyHandler: function() {
return jQuery('#build-parameters-${buildGrid.get(0,0).getId()}').html();
}
});
</script>
<st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.extension.AbstractNameValueHeader.build-parameters-tooltip"/>
</j:otherwise>
</j:choose>
</div>
Expand Down