Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT FOR TESTING - CSP TICKETS #152

Draft
wants to merge 89 commits into
base: master
Choose a base branch
from

Conversation

shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Nov 4, 2024

Temporary draft PR to test CSP compatibility for all of the following tickets as they are interdependent:

  1. [JENKINS-73960] Extract event handlers in BuildCardExtension/buildCardTemplate.jelly #142
  2. [JENKINS-73961] Extract event handlers in BuildPipelineView/bpp.jelly #144
  3. [JENKINS-74053] Extract inline script block in BuildPipelineView/configure-entries.jelly #145
  4. [JENKINS-74057] Extract inline script block in BuildCardExtension/buildCardHelpers.jelly #146
  5. [JENKINS-74054] Extract inline script block in AbstractNameValueHeader/rowHeader.jelly #147
  6. [JENKINS-74056] Extract JS in PipelineHeaderExtension/columnHeader.jelly #148
  7. [JENKINS-74055] Extract inline script block in BuildPipelineView/main_dashboard.jelly #149
  8. [JENKINS-74806] Extract inline script bpp.jelly BuildPipelineView/bpp.jelly  #150
  9. Bump jenkins to 2.426.3 (to update jQuery3 plugin) #153
  10. Require Jenkins 2.452.3 or newer #154

Related PRs:

  1. Fix jQuery target element for tooltip to work correctly in AbstractNameValueHeader/rowHeader.jelly #156
  2. Mask negative bits to prevent negative projectIds in BuildForm.java and ProjectForm.java #157
  3. Fix: build-cards not updating automatically without page refresh #158

Requires minimum Jenkins version: 2.426.3 in order to update jQuery3 API plugin to 3.7.1-2 which addresses this csp issue -> Needs to be pushed to **2.452.3** to update stapler to 1839.ved17667b_a_eb_5 which contains:



Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…ildpipeline/BuildPipelineView/configure-entries.jelly
…ildpipeline/BuildPipelineView/configure-entries.jelly
…ildpipeline/BuildPipelineView/configure-entries.jelly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant