Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-25083] use MailAddressResolver for retrieving user email instead of UserProperty #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabiodcasilva
Copy link
Contributor

@fabiodcasilva fabiodcasilva commented Nov 2, 2024

This pull request addresses [build-user-vars-plugin] - Improper resolution of user e-mails](https://issues.jenkins.io/browse/JENKINS-25083)

Follow-up to: Commit 3ff2b523e9663b485ed0cbdb3ab129b64bd5e179

The previous implementation for resolving user email addresses directly utilized UserProperty, which was identified as an improper method for this task. Instead, MailAddressResolver should be used which is specifically designed for inferring email addresses.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@fabiodcasilva fabiodcasilva requested a review from a team as a code owner November 2, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant