Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sendCloudEvent method of sinks.HttpSink #10

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Oct 30, 2023

What

Should judge null when get jenkins http proxy setting.

Why

Fixes #9

How

How is it doing what it does?
How to test, how to integrate, any relevant compromises, etc.?

Changes details

  • Detail one
  • Detail two
    ...

Missed anything?

  • Explained the purpose of this PR.
  • Self reviewed the PR.
  • Added or updated test cases.
  • Informed of breaking changes, testing and migrations (if applicable).
  • Updated documentation (if applicable).
  • Attached screenshots (if applicable).

Should judge null when get jenkins http proxy setting.

Fixes jenkinsci#9
Copy link
Member

@rorybakerfmr rorybakerfmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - looks good to me

@rorybakerfmr rorybakerfmr merged commit fd5144a into jenkinsci:main Dec 15, 2023
13 of 14 checks passed
@wuhuizuo wuhuizuo deleted the wuhuizuo/issue9 branch August 2, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should judge null when get jenkins http proxy setting
2 participants