Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fat aws-java-sdk with fine-grained aws-java-sdk-kinesis #14

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

Vlatombe
Copy link
Member

What

This replaces the fat plugin aws-java-sdk with the fine-grained plugin aws-java-sdk-kinesis that is used from this plugin (judging from imports).

Why

The aws-java-sdk plugin is very heavyweight, using the modular plugin instead allows to reduce the overall size of the installation without removing any feature.

How

I don't know anything about this plugin, only that it could avoid pulling this big dependency ;)

Changes details

  • Detail one
  • Detail two
    ...

Missed anything?

  • Explained the purpose of this PR.
  • Self reviewed the PR.
  • Added or updated test cases.
  • Informed of breaking changes, testing and migrations (if applicable).
  • Updated documentation (if applicable).
  • Attached screenshots (if applicable).

@rorybakerfmr
Copy link
Member

Looks good to me, thank you!

@rorybakerfmr rorybakerfmr merged commit c74e079 into jenkinsci:main Apr 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants