Create reports under Build Artifacts(AST-64900) #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrShamirCM
reviewed
Nov 5, 2024
| @@ -356,6 +356,31 @@ public void close() throws IOException { | |||
| ArtifactArchiver artifactArchiverJson = new ArtifactArchiver(workspace.toURI().relativize(jsonReportFilePath.toURI()).toString()); | |||
| artifactArchiverJson.perform(run, workspace, envVars, launcher, listener); | |||
|
|
|||
| if (scanConfig.getAdditionalOptions().contains("--report-format")) { | |||
There was a problem hiding this comment.
maybe set it in another private method with a name that will describe what you ar doing here
OrShamirCM
reviewed
Nov 5, 2024
OrShamirCM
reviewed
Nov 5, 2024
| @@ -103,6 +110,39 @@ public void failWrongCheckmarxInstallation() throws Exception { | |||
| this.jenkins.assertBuildStatus(Result.FAILURE, build); | |||
| this.jenkins.assertLogContains("Please configure the build properly and retry.", build); | |||
| } | |||
| @Test | |||
| public void successCheckmarxScanAndVerifyArtifacts() throws Exception { | |||
There was a problem hiding this comment.
please update ethe test name inder when_given_then(should) concentration and have comments of the steps cause it's hard to understand what it does
|
Policy Management Violations
Fixed Issues
|
OrShamirCM
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the report files generated under Build Artifacts to allow easy access.
Testing:
Added an integration test that builds a job and runs a scan with report generation parameters, checking whether the expected files are present in the archive.
Submitter checklist