Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link againts API plugin including commons-compress because removal from core #342

Closed

Conversation

jonesbusy
Copy link

See JENKINS-73355 (jenkinsci/jenkins#9958)

Also link againts API plugin like gson-api or commons-lang3-api instead of a copy of dependencies

This increase also the minimum core version to match recommended version https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/#currently-recommended-versions

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy force-pushed the feature/commons-compress-api-plugin branch from 7a7440e to 92b5146 Compare November 12, 2024 07:05
@jonesbusy
Copy link
Author

Hi @pedrompflopes

Can you take a look at this ? Also I don't understand why those custom GHA workflows are failing. Build looks ok on ci.jenkins.io

Also a release would be required after merge

We are removing commons-compress from jenkins core. This PR link the plugin with the respective API plugin to avoid the plugin to stop to work when a next Jenkins weekly release will be available.

Thanks

@OrShamirCM
Copy link
Collaborator

@jonesbusy thank you for your help and contribution! please check our PR - #346
We fixed our dependencies there and added your changes. let me know if we need to make more changes, please.
Thanks, Or

@jonesbusy jonesbusy closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants