Update build parent to 3.4 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <version>1.4.8</version> | ||
| <packaging>hpi</packaging> | ||
| <properties> | ||
| <jenkins.version>1.625</jenkins.version> |
There was a problem hiding this comment.
Suggested change
| <jenkins.version>1.625</jenkins.version> | |
| <jenkins.version>2.60.3</jenkins.version> |
If you want to support Java 8 only, we need to use the core version which supports Java 8 only
| @@ -0,0 +1,10 @@ | |||
| <!-- FindBugs exclude file --> | |||
| <!-- This is just a (currently unused, as-yet invalid) template. If you want | |||
saper
suggested changes
May 2, 2020
| // JENKINS-7999 is fixed, so now use Jenkins FilePath instead of the | ||
| // custom MyFilePath included in this plugin | ||
| rootFilePathOnMaster.copyRecursiveTo(includes, excludes, | ||
| projectWorkspaceOnSlave); |
There was a problem hiding this comment.
This removes silently the flatten feature from https://issues.jenkins-ci.org/browse/JENKINS-8220
|
|
||
| <scm> | ||
| <connection>scm:git:ssh://github.com:jmcgeheeiv/copy-to-slave-plugin.git</connection> | ||
| <developerConnection>scm:git:ssh://[email protected]/jmcgeheeiv/copy-to-slave-plugin.git</developerConnection> |
There was a problem hiding this comment.
do we want this change in the published pom.xml?
|
|
||
| <issueManagement> | ||
| <url>https://github.com/jenkinsci/copy-to-slave-plugin/issues</url> | ||
| <system>GitHub</system> |
There was a problem hiding this comment.
Issues for this plugin are currently managed on the Jenkins JIRA, not on GitHub; in fact, GitHub issues are disabled as of 2020-05-03
| <organization> | ||
| <name>Wave Computing, Inc.</name> | ||
| <url>http://www.wavecomp.ai</url> | ||
| </organization> |
There was a problem hiding this comment.
Is Wave Computing now supporting the plugin...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains mainly a modernized build:
MyFilePathwith the standardFilePath. Original author Romain Seguy usedMyFilePathto work around some problems he found in the standardFilePath. Then he fixed the standardFilePathper JENKINS-7999.IMPORTANTLY, THE SECURITY PROBLEM WITH THIS PLUGIN REMAINS.