[JENKINS-74060][JENKINS-74061][JENKINS-74062] Remove legacy checkUrl validation
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavafenkin
commented
Nov 8, 2024
| @@ -67,7 +67,7 @@ THE SOFTWARE. | |||
| <f:repeatable field="authentication"> | |||
| <local:blockWrapper> | |||
| <f:entry field="cvsRoot" title="${%CVS Root}"> | |||
| <f:textbox name="cvsAuthentication.cvsRoot" checkUrl="'descriptorByName/CVSSCM/checkAuthenticationCvsRoot?value='+escape(this.value)" /> | |||
| <f:textbox name="cvsAuthentication.cvsRoot" checkUrl="descriptorByName/CVSSCM/checkAuthenticationCvsRoot" checkDependsOn="" /> | |||
There was a problem hiding this comment.
Suggested change
| <f:textbox name="cvsAuthentication.cvsRoot" checkUrl="descriptorByName/CVSSCM/checkAuthenticationCvsRoot" checkDependsOn="" /> | |
| <f:textbox name="cvsAuthentication.cvsRoot" checkUrl="${it.descriptor.descriptorUrl}/checkAuthenticationCvsRoot" checkDependsOn="" /> |
Would be cleaner, but I've tried to keep the diff smaller. Can change if someone has strong opinion on this.
| @@ -38,8 +38,10 @@ THE SOFTWARE. | |||
| <table> | |||
| <f:block> | |||
| ${%Choose the CVS tag name for this build}: | |||
| <f:textbox name="name" value="jenkins-${it.build.number}" | |||
| checkUrl="'checkTag?value='+encodeURIComponent(this.value)"/> <br /> | |||
| <f:entry> | |||
There was a problem hiding this comment.
This adds the markup needed for validation to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-74060
https://issues.jenkins.io/browse/JENKINS-74061
https://issues.jenkins.io/browse/JENKINS-74062
Testing done
I haven't manually tested the validation of
LegacyTagAction. I've applied the same exact fix as forCvsTagActionas those two actions are similar.Before the change
After the change
Submitter checklist