Add dependency check results to Jenkins REST API #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfalco79
reviewed
Sep 22, 2023
|
|
||
| @GET | ||
| @WebMethod(name = "findings") | ||
| public JsonHttpResponse getFindingsExposedInRemoteApi() { |
There was a problem hiding this comment.
I would not expose result unless a valid use case
| @@ -135,4 +143,47 @@ public JSONObject getSeverityDistributionJson() { | |||
| return JSONObject.fromObject(getSeverityDistribution(), jsonConfig); | |||
| } | |||
|
|
|||
| public Api getApi() { | |||
| return new Api(this); | |||
There was a problem hiding this comment.
in this case we have to return only severity distribution so you can return new Api(getSeverityDistribution()) without add all other methods (getSeverityDistribution trigger a lock) and keep the buildaction clean
| @@ -135,4 +143,47 @@ public JSONObject getSeverityDistributionJson() { | |||
| return JSONObject.fromObject(getSeverityDistribution(), jsonConfig); | |||
| } | |||
|
|
|||
| public Api getApi() { | |||
There was a problem hiding this comment.
Miss API documentation (_api.jelly in the parent object folder)
nfalco79
force-pushed
the
master
branch
3 times, most recently
from
9631fc7 to
dc2b961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft/sketch for adding dependency check findings to Jenkins REST API.
Please see https://issues.jenkins.io/browse/JENKINS-72062 for details.