Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin CSP compliant #78

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

yaroslavafenkin
Copy link
Contributor

  • [JENKINS-74136][JENKINS-74142] Extract inline JavaScript
  • [JENKINS-74138][JENKINS-74139][JENKINS-74140] Extract inline JavaScript
  • [JENKINS-74137] Extract inline JavaScript from FortifyPlugin/config.jelly
  • [JENKINS-74141] Extract inline JavaScript from FortifyPlugin/global.jelly

Testing done

I did not set up full integration with fortify services. In my testing I've focused on making sure input parameters for functions that are called are the same before and after my changes.

Before the change
After the change

Before the change
After the change

Before the change
After the change

Before the change
After the change

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@@ -123,7 +123,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>gradle</artifactId>
<version>2.9</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.9 doesn't exist in https://repo.jenkins-ci.org/artifactory/releases/org/jenkins-ci/plugins/gradle/, so project wasn't building for me locally.

Copy link
Contributor

@akarjakina akarjakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Great stuff.

Copy link
Contributor

@akaryakina akaryakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@akaryakina akaryakina merged commit ecdb47f into jenkinsci:master Jan 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants