Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative URLs for documentation images (images:/ to images:) #1206

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Jan 16, 2022

Related to jenkins-infra/plugin-site#961 - some of the current images are linked to the root of the repo.

I'm leaving it as draft as I'm not sure what the right solution is yet.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Dependency or infrastructure update

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 16, 2022
@MarkEWaite
Copy link
Contributor

I think it is an improvement and a good correction, even if it does not ultimately resolve the issue you're fixing.

@MarkEWaite MarkEWaite changed the title images:/ to images: Use relative URLs for documentation images (images:/ to images:) Jan 16, 2022
@MarkEWaite
Copy link
Contributor

@halkeye any reason that I should not merge this improvement?

@halkeye
Copy link
Member Author

halkeye commented Jan 17, 2022

Honestly? It's selfishly my test case for plugins site. It's currently not breaking anything and its a known scenario so I was gonna dig into it once I finish Jenkins it the way

@MarkEWaite
Copy link
Contributor

Honestly? It's selfishly my test case for plugins site. It's currently not breaking anything and its a known scenario so I was gonna dig into it once I finish Jenkins it the way

Super. I'll leave it in draft and not worry about it. If it is helping you and not hindering you, then I'm happy to have it remain as a draft PR

@MarkEWaite MarkEWaite marked this pull request as ready for review August 5, 2024 00:00
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 5, 2024 00:00
@MarkEWaite MarkEWaite merged commit 166e4ad into jenkinsci:master Aug 5, 2024
4 of 5 checks passed
@MarkEWaite
Copy link
Contributor

I merged this since I believe that @halkeye is not active on the plugins site any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants