Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test conditionals for unsupported git versions #1629

Merged

Conversation

MarkEWaite
Copy link
Contributor

Remove test conditionals for unsupported git versions

Operating systems that provided versions of command line git older than 2.30 are no longer supported by their upstream providers and are thus no longer supported by the Jenkins project. Remove the special cases in the tests for those unsupported operating systems.

Testing done

Confirmed that automated tests pass with Java 21 on Linux. Rely on ci.jenkins.io to test Windows and Java 17.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Operating systems that provided versions of command line git older than
2.30 are no longer supported by their upstream providers and are thus
no longer supported by the Jenkins project.  Remove the special cases
in the tests for those unsupported operating systems.
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 6, 2024 22:46
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Aug 6, 2024
@github-actions github-actions bot added the tests Automated test addition or improvement label Aug 6, 2024
@MarkEWaite MarkEWaite removed the test Automated test addition or improvement label Aug 6, 2024
@MarkEWaite MarkEWaite enabled auto-merge (squash) August 6, 2024 22:52
@MarkEWaite MarkEWaite merged commit 59f2bee into jenkinsci:master Aug 6, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the remove-git-version-test-conditionals branch August 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant