Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary version declarations #1680

Conversation

MarkEWaite
Copy link
Contributor

Remove unnecessary version declarations

Plugin BOM now includes the necessary versions. Rely on plugin BOM versions instead of maintaining them separately in this pom file.

Testing done

Confirmed versions match with mvn help:effective-pom before and after this change.

Confirmed that automated tests pass.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Plugin BOM now includes the necessary versions.  Rely on plugin BOM
versions instead of maintaining them separately in this pom file.

Confirmed versions match with `mvn help:effective-pom` before and after
this change.
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 19, 2024 10:26
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Oct 19, 2024
@github-actions github-actions bot added the dependencies Dependency related change label Oct 19, 2024
@MarkEWaite MarkEWaite removed the dependencies Dependency related change label Oct 19, 2024
@MarkEWaite MarkEWaite merged commit eecf8fc into jenkinsci:master Oct 19, 2024
18 checks passed
@MarkEWaite MarkEWaite deleted the remove-unnecessary-version-declarations branch November 5, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant