Fix an exception when the authentication token is not exactly which i…

…s expected from the plugin
jenkinsci · Nov 1, 2023 · b34794c · b34794c
1 parent 818ad9b
commit b34794c
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java b/src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
@@ -753,10 +753,15 @@ public int hashCode() {
     @Override
     public GroupDetails loadGroupByGroupname(String groupName)
             throws UsernameNotFoundException, DataAccessException {
-        GithubAuthenticationToken authToken =  (GithubAuthenticationToken) SecurityContextHolder.getContext().getAuthentication();
-
-        if(authToken == null)
+        Authentication authentication = SecurityContextHolder.getContext().getAuthentication();
+        if (authentication == null) {
             throw new UsernameNotFoundException("No known group: " + groupName);
+        }
+        if (!(authentication instanceof GithubAuthenticationToken)) {
+            throw new UserMayOrMayNotExistException("The received token is not a GitHub one");
+        }
+
+        GithubAuthenticationToken authToken = (GithubAuthenticationToken) authentication;
 
         try {
             int idx = groupName.indexOf(GithubOAuthGroupDetails.ORG_TEAM_SEPARATOR);