Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Gradle Enterprise to Develocity #382

Merged
merged 10 commits into from
Dec 27, 2023
Merged

Rename Gradle Enterprise to Develocity #382

merged 10 commits into from
Dec 27, 2023

Conversation

welandaz
Copy link
Member

This PR renames Gradle Enterprise to Develocity in README (incl. screenshots), UI elements and parts of the code.

Environment variables that are used for autoinjection were not renamed.

@welandaz welandaz requested review from alextu and c00ler December 20, 2023 07:39
@welandaz welandaz self-assigned this Dec 20, 2023
guylabs
guylabs approved these changes Dec 20, 2023
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
images/enriched-build-scans-configuration.png Outdated Show resolved Hide resolved
alextu
alextu approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@alextu alextu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although:

  • one acceptance test is failing
  • we should test the upgrade path

@alextu
Copy link
Contributor

alextu commented Dec 27, 2023

I've tested the upgrade path:

  • given installed plugin 2.9 version
  • checked on maven freestyle, gradle freestyle, gradle pipeline jobs that injection works
  • manually deployed build from this branch
  • restarted
  • checked visually that "Develocity" appears in the UI
  • checked on existing maven freestyle, gradle freestyle, gradle pipeline jobs that injection still works

@alextu alextu merged commit e3d4bff into master Dec 27, 2023
11 checks passed
@alextu alextu deleted the welandaz/gradle-enterprise-renaming branch December 27, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextu alextu alextu approved these changes

@guylabs guylabs guylabs approved these changes

@c00ler c00ler Awaiting requested review from c00ler

Assignees

@welandaz welandaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@welandaz @alextu @guylabs