Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.479.1 and Jakarta EE 9 #125

Merged

Conversation

MarkEWaite
Copy link
Contributor

Require Jenkins 2.479.1 and Jakarta EE 9

Reviewed dependent plugins and found no usages of the modified APIs. Plugins that were reviewed:

  • Ivy Report
  • Artifactory
  • Environment Injector
  • Multi-Branch Project Plugin (DEPRECATED)
  • Release
  • scripted Cloud

Retained one deprecated method signature StaplerRequest for

IvyReporterDescriptor.newInstance(org.kohsuke.stapler.StaplerRequest req)

since that method unconditionally returned null before and should be harmless to continue returning null.

Testing done

Unpacked https://dlcdn.apache.org//ant/ivy/2.5.3/apache-ivy-2.5.3-bin-with-deps.tar.gz and copied the ivy-2.5.3.jar file and all the lib/* files into the lib directory of my Apache Ant installation. Created a freestyle project that users Apache Ivy to build src/test/resources/example-project/modules.

Confirmed a sample https://github.com/MarkEWaite/ant-ivy-java-example.git passes from the adapt-to-latest-ivy branch

Automated tests pass on Java 21.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Reviewed dependent plugins and found no usages of the modified APIs.
Plugins that were reviewed:

* Ivy Report
* Artifactory
* Environment Injector
* Multi-Branch Project Plugin (DEPRECATED)
* Release
* scripted Cloud

Retained one deprecated method signature StaplerRequest for

  IvyReporterDescriptor.newInstance(org.kohsuke.stapler.StaplerRequest req)

since that method unconditionally returned null before and should be
harmless to continue returning null.

Testing done

Unpacked https://dlcdn.apache.org//ant/ivy/2.5.3/apache-ivy-2.5.3-bin-with-deps.tar.gz
and copied the ivy-2.5.3.jar file and all the lib/* files into the lib
directory of my Apache Ant installation.  Created a freestyle project
that users Apache Ivy to build src/test/resources/example-project/modules.

Confirmed a sample https://github.com/MarkEWaite/ant-ivy-java-example.git
passes from the adapt-to-latest-ivy branch

Automated tests pass on Java 21.
@MarkEWaite MarkEWaite requested a review from a team as a code owner February 3, 2025 15:26
@MarkEWaite MarkEWaite added the enhancement New feature label Feb 3, 2025
@MarkEWaite MarkEWaite merged commit 27386e7 into jenkinsci:master Feb 3, 2025
17 checks passed
@MarkEWaite MarkEWaite deleted the require-jenkins-2.479.1-or-newer branch February 3, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant