[JENKINS-75003] Zip-based tool installer configuration incorrectly re…

…jects non-HTTP(S) URLs (regression in 2.379) (#10065) [JENKINS-75003] Zip-based tool installer configuration incorrectly rejects non-HTTP(S) URLs
jenkinsci · Dec 17, 2024 · 34aba67 · 34aba67
1 parent f1b6d31
commit 34aba67
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/core/src/main/java/hudson/tools/ZipExtractionInstaller.java b/core/src/main/java/hudson/tools/ZipExtractionInstaller.java
@@ -43,6 +43,8 @@
 import java.net.http.HttpClient;
 import java.net.http.HttpRequest;
 import java.net.http.HttpResponse;
+import java.nio.file.FileSystemNotFoundException;
+import java.nio.file.Path;
 import jenkins.MasterToSlaveFileCallable;
 import jenkins.model.Jenkins;
 import org.jenkinsci.Symbol;
@@ -117,6 +119,14 @@ public FormValidation doCheckUrl(@QueryParameter String value) throws Interrupte
             } catch (URISyntaxException e) {
                 return FormValidation.error(e, Messages.ZipExtractionInstaller_malformed_url());
             }
+            if (uri.getScheme() != null && !uri.getScheme().startsWith("http")) {
+                try {
+                    Path.of(uri);
+                    return FormValidation.ok();
+                } catch (FileSystemNotFoundException | IllegalArgumentException e) {
+                    return FormValidation.error(e, Messages.ZipExtractionInstaller_malformed_url());
+                }
+            }
             HttpClient httpClient = ProxyConfiguration.newHttpClient();
             HttpRequest httpRequest;
             try {