Trim the environment variables keys and values #10024
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in trimming of the node environment variables key and value values. If you enter values in either fields with leading spaces, trailing spaces or leading and trailing spaces, those spaces would stay and the environment variables would not load. This becomes a real problem when adding
BASE+EXTRA
values, such asPATH+LOCAL_BIN
.This change trims the
key
andvalue
values.Testing done
mvn -am -pl war,bom -Pquick-build clean install
mvn -Dtest=EnvironmentVariableNodePropertyTest verify -Dskip.yarn -Dskip.corepack
Proposed changelog entries
key
andvalue
values for Node environment variables.Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist