Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aborted and disabled icon colours themable #10032

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jonny-vb
Copy link

@Jonny-vb Jonny-vb commented Dec 6, 2024

Update the aborted and disabled icon colours to be set from variables instead of hard coded colours, allowing them to be overwritten by themes.

See:
jenkinsci/dark-theme-plugin#550
jenkinsci/dark-theme-plugin#552

Testing done

No tests written as is a pure UI update

Proposed changelog entries

  • Make pipeline icons for aborted and disabled themeable

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@timja

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

Copy link

welcome bot commented Dec 6, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@janfaracik janfaracik added the web-ui The PR includes WebUI changes which may need special expertise label Dec 6, 2024
Copy link
Contributor

@janfaracik janfaracik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - need to confirm this is needed though jenkinsci/dark-theme-plugin#550 (comment)

@janfaracik janfaracik added the skip-changelog Should not be shown in the changelog label Dec 6, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to understand this before we proceed:
jenkinsci/dark-theme-plugin#550 (comment)

but once thats understood this is good

@timja
Copy link
Member

timja commented Dec 7, 2024

@janfaracik has figured it out in jenkinsci/dark-theme-plugin#550 (comment)

This needs fixing in branch-api-plugin

@timja
Copy link
Member

timja commented Dec 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants