-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap app bars on smaller screens #10119
Open
janfaracik
wants to merge
12
commits into
jenkinsci:master
Choose a base branch
from
janfaracik:responsive-app-bar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+100
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janfaracik
added
web-ui
The PR includes WebUI changes which may need special expertise
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
accessibility
Improve accessibility per WCAG guidelines
labels
Jan 6, 2025
A1exKH
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janfaracik LGTM.
Seeing something like this in the error log, looks formatting related: 20:06:06 [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:corepack (prettier) on project jenkins-parent: Failed to run task: 'corepack yarn exec prettier --check .' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
20:06:06 org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:corepack (prettier) on project jenkins-parent: Failed to run task |
Ah missed that - thanks! |
Hey you are welcome! |
krisstern
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
Improve accessibility per WCAG guidelines
rfe
For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
web-ui
The PR includes WebUI changes which may need special expertise
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our App bars don't currently behave very well on smaller screens, such as phones/tablets/snapped windows. These PR aims to alleviate some of those issues by wrapping controls where appropriate, or aligning them side by side (and filling the remaining white space). This isn't perfect but should be a reasonable improvement for users on smaller devices. This shouldn't have any impact on larger devices.
Testing done
Desktop (before)
Desktop (after)
Phone (before)
Phone (after)
Phone (before)
Phone (after)
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist