Feature/token

[reftel]

Description

See JENKINS-66449.

This change lets users pick StringCredentials in addition to UsernamePasswordCredentials in the credentials drop-down in the settings. This makes the SigningInterceptor send the secret of the credential as a bearer token, instead of using username and password for Basic Authentication. See https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html for the documentation on the Jira side.

There are automated tests in SingningInterceptorTest.

This can be tested manually by adding a Personal Access Token on a Jira instance, and add that as a String Credential in Jenkins. Then add a new site in the settings of jira-steps-plugin for that Jira instance, and choose Credentials as login type, and pick the new credential in the drop-down. Verify that a pipeline can run Jira steps using the new site.

Submitter checklist

• Link to JIRA ticket in description, if appropriate.
• Change is code complete and matches issue description.
• Appropriate unit or acceptance tests or explanation to why this change has no tests.
• Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

• Run the changes and verified the change matches the issue description.
• Reviewed the code.
• Verified that the appropriate tests have been written or valid explanation given.
• If applicable, tested by installing this plugin on the Jenkins instance.

[reftel]

Ping @nrayapati

[reftel]

Ping @nrayapati

[jiricermak-sap]

@nrayapati can you please review?

[KylanZhang]

@nrayapati @nfalco79 Can you review this PR? This is a very useful feature.

[faminepq]

i'm already using code from this PR for some time, and eveything works fine for me - is there any chance to see it merged into master?

[nfalco79]

I'm not the mantainer, so my code review is useless to proceed with merge

[akulakhan]

This is critically needed, my org has forced a move to disabling basic auth, and oauth is not supported, so this would be the only way to continue using this plugin.

[faminepq]

This is critically needed, my org has forced a move to disabling basic auth, and oauth is not supported, so this would be the only way to continue using this plugin.

I'm in the same situation, had to locally build code from the fork and upload it manually... Anyway seems like this plugin is abandoned :-( @nrayapati

[faminepq]

@reftel After upgrading Jenkins to latest LTS - i've started getting Parameter specified as non-null is null: method okhttp3.Credentials.basic, parameter username (also for Test Connection button click). Have not updated jenkins for cca 2 months, previously everything worked fine. Any tip what might be the problem? Everything is set as before (i'm restoring configs&secrets from backup).

[reftel]

Looks to me like the only place where that method is called is when setting up proxy authentication. You should be able to get that exception if you have proxyConfiguration being non-null, but proxyConfiguration.getUserName() returning null. Are you using a proxy that requires authentication? If not, could you please check if you have a partially filled in proxy authentication configuration ("HTTP Proxy Configuration" in the global Jenkins configuration, not specific to Jira Steps) that you could delete?

[faminepq]

Thank you for quick response. We use/need proxy + port + no_proxy settings, but we're not using username & password. Alas, i cannot delete all proxy settings, since we need it.

In Jenkins changelog i've found this change, which might be related to the problem: https://github.com/jenkinsci/jenkins/pull/8990/files

Anyway once i've removed on our test server all proxy settings, it started working... but proxy settings are needed for other urls.

[faminepq]

So the problem is not in your PR, it's for another PR... Change in screenshot above fixed the issue for me. So it was really caused by this jenkins change: https://github.com/jenkinsci/jenkins/pull/8990

[reftel]

Fixed in 8c4a487 . Thank you!